Skip to content

CallExpressions to TaggedTemplateLiterals #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boopathi wants to merge 1 commit into from
Closed

CallExpressions to TaggedTemplateLiterals #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/babel-plugin-minify-simplify/__tests__/simplify-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ const plugin = require("../src/index");
const comparisonPlugin = require("../../babel-plugin-transform-simplify-comparison-operators/src");
const unpad = require("../../../utils/unpad");

function transform(code) {
function transform(code, options) {
return babel.transform(code, {
plugins: [plugin],
plugins: [ [plugin, options] ],
}).code;
}

Expand Down Expand Up @@ -2643,4 +2643,19 @@ describe("simplify-plugin", () => {
}
expect(transform(source)).toBe(expected);
});

it("should convert call expressions with single string param to tagged templates", () => {
const source = unpad(`
foo("bar");
bar.baz("", "");
bar(a);
baz(5);
baz.foo.bar(4)("foo");
baz("bar", "")(5);
(() => {})("bar");
quux(foo(\`as\${d}f\`));
`);
const expected = "foo`bar`, bar.baz(\"\", \"\"), bar(a), baz(5), baz.foo.bar(4)`foo`, baz(\"bar\", \"\")(5), (() => {})`bar`, quux(foo(`as${ d }f`));";
expect(transform(source, { callsToTags: true })).toBe(expected);
});
});
31 changes: 31 additions & 0 deletions packages/babel-plugin-minify-simplify/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,37 @@ module.exports = ({ types: t }) => {
}*/
// },

CallExpression: {
enter: [
// Converts
// foo("bar") -> foo`bar`
function CallExprToTaggedTemplate(path, {
opts: {
ecmaVersion = 2015,
callsToTags = false
}
}) {
if (ecmaVersion < 2015 || !callsToTags) return;

const args = path.get("arguments");

if (args.length !== 1) return;
if (!args[0].isStringLiteral()) return;

const callee = path.get("callee");

path.replaceWith(
t.taggedTemplateExpression(
callee.node,
t.templateLiteral(
[ t.templateElement({ raw: args[0].node.value }, true) ], []
)
)
);
}
]
},

UnaryExpression: {
enter: [

Expand Down
4 changes: 4 additions & 0 deletions packages/babel-preset-babili/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ function preset(context, _opts = {}) {
proxy("keepClassName", [
optionsMap.mangle,
optionsMap.deadcode
]),

proxy("ecmaVersion", [
optionsMap.simplify
])
],
"some"
Expand Down