Skip to content

optimize numeric literals properly [fixes #459]#467

Closed
vigneshshanmugam wants to merge 4 commits intobabel:masterfrom
vigneshshanmugam:fix-numeric
Closed

optimize numeric literals properly [fixes #459]#467
vigneshshanmugam wants to merge 4 commits intobabel:masterfrom
vigneshshanmugam:fix-numeric

Conversation

@vigneshshanmugam
Copy link
Copy Markdown
Member

  • combination of parseFloat and toExponential

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Mar 8, 2017

Hey @vigneshshanmugam! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@vigneshshanmugam
Copy link
Copy Markdown
Member Author

@hzoo Fixed it. Thanks :)

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Mar 9, 2017
@vigneshshanmugam
Copy link
Copy Markdown
Member Author

vigneshshanmugam commented Mar 12, 2017

@boopathi There is a existing PR #349 which i just saw today, But it lacks some of the optimizations..

We should converge both and go with the one that performs better in most cases.

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Mar 12, 2017

Hey @vigneshshanmugam! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@bardiharborow
Copy link
Copy Markdown
Contributor

@vigneshshanmugam I've started updating my PR, and I'll work on merging the two.

@vigneshshanmugam
Copy link
Copy Markdown
Member Author

Closing it in favour of #349

@vigneshshanmugam vigneshshanmugam deleted the fix-numeric branch August 18, 2017 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tag: Bug Fix Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants