fix(minify-dead-code): fix #601#602
Merged
boopathi merged 4 commits intobabel:masterfrom Jun 27, 2017
postspectacular:remove-strict-fix
Merged
fix(minify-dead-code): fix #601#602boopathi merged 4 commits intobabel:masterfrom postspectacular:remove-strict-fix
boopathi merged 4 commits intobabel:masterfrom
postspectacular:remove-strict-fix
Conversation
Contributor
postspectacular
commented
Jun 23, 2017
postspectacular
commented
- add block checks to getUseStrictDirectives()
- add block checks to getUseStrictDirectives()
| return block.get("directives").filter(directive => { | ||
| return directive.node.value.value === useStrict; | ||
| }); | ||
| var dir = block.get("directives"); |
Member
There was a problem hiding this comment.
why not check for array? Array.isArray()
Member
|
Can you also add a test case for this ? |
Contributor
Author
|
@boopathi there already is a test for this. I still don't know how to produce a minimal example of the case triggering the original error. The existing test does succeed for the fix, though and the fix also allows me to process my project codebase now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.