Skip to content

Refactor the test suite #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boopathi merged 4 commits into from
Jun 30, 2017
Merged

Refactor the test suite #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b12566c
Add test helper
j-f1 Jun 18, 2017
be7e0ce
Copy-edit test names
j-f1 Jun 29, 2017
97a53cd
Fix build
j-f1 Jun 29, 2017
0ef0821
Add support for thePlugin.only
j-f1 Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
317 changes: 155 additions & 162 deletions packages/babel-plugin-minify-builtins/__tests__/minify-builtins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,187 +1,180 @@
jest.autoMockOff();

const babel = require("babel-core");
const unpad = require("../../../utils/unpad");
const plugin = require("../src/index");

function transform(code) {
return babel.transform(code, {
plugins: [plugin]
}).code;
}
const thePlugin = require("../../../utils/test-transform").snapshot(
require("../src/index")
);

describe("minify-builtins", () => {
it("should minify standard built in methods", () => {
const source = unpad(`
function c() {
let a = 10;
const d = Number.isNaN(a);
Math.max(a, b) + Math.max(b, a);
return d && Number.isFinite(a);
}
`);
// Jest arranges in alphabetical order, So keeping it as _source
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should minify standard built in methods",
`
function c() {
let a = 10;
const d = Number.isNaN(a);
Math.max(a, b) + Math.max(b, a);
return d && Number.isFinite(a);
}
`
);

it("should minify standard built in properties", () => {
const source = unpad(`
function a () {
Number.NAN + Number.NAN;
return Math.PI + Math.PI + Number.EPSILON + Number.NAN;
}
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should minify standard built in properties",
`
function a () {
Number.NAN + Number.NAN;
return Math.PI + Math.PI + Number.EPSILON + Number.NAN;
}
`
);

it("should take no of occurences in to account", () => {
const source = unpad(`
function a() {
Math.floor(a) + Math.floor(b) + Math.min(a, b);
}
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should take no of occurences in to account",
`
function a() {
Math.floor(a) + Math.floor(b) + Math.min(a, b);
}
`
);

it("should collect and minify no matter any depth", () => {
const source = unpad(`
function a (){
Math.max(b, a);
const b = () => {
const a = Math.floor(c);
Math.min(b, a) * Math.floor(b);
function c() {
Math.floor(c) + Math.min(b, a)
}
thePlugin(
"should collect and minify no matter any depth",
`
function a (){
Math.max(b, a);
const b = () => {
const a = Math.floor(c);
Math.min(b, a) * Math.floor(b);
function c() {
Math.floor(c) + Math.min(b, a)
}
}
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
}
`
);

it("shouldn't minify builtins in the program scope to avoid leaking", () => {
const source = unpad(`
Math.max(c, d)
function a (){
Math.max(b, a) + Math.max(c, d);
}
Math.max(e, f)
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"shouldn't minify builtins in the program scope to avoid leaking",
`
Math.max(c, d)
function a (){
Math.max(b, a) + Math.max(c, d);
}
Math.max(e, f)
`
);

it("should minify builtins to method scope for class declarations", () => {
const source = unpad(`
class Test {
foo() {
Math.max(c, d)
thePlugin(
"should minify builtins to method scope for class declarations",
`
class Test {
foo() {
Math.max(c, d)
Math.max(c, d)
const c = function() {
Math.max(c, d)
const c = function() {
Math.max(c, d)
Math.floor(m);
Math.floor(m);
}
}
bar() {
Math.min(c, d)
Math.min(c, d)
Math.floor(m);
Math.floor(m);
}
}
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
bar() {
Math.min(c, d)
Math.min(c, d)
}
}
`
);

it("should minify builtins to function scopes ", () => {
const source = unpad(`
var a = () => {
Math.floor(b);
Math.floor(b);
c: () => {
Math.floor(d);
Math.max(2,1);
}
thePlugin(
"should minify builtins to function scopes ",
`
var a = () => {
Math.floor(b);
Math.floor(b);
c: () => {
Math.floor(d);
Math.max(2,1);
}
A.b("asdas", function() {
Math.floor(d) + Math.max(d,e);
Math.max(e,d);
})
A.b("asdas1", function() {
Math.floor(d) + Math.floor(d,e);
Math.max(e,d);
})
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
}
A.b("asdas", function() {
Math.floor(d) + Math.max(d,e);
Math.max(e,d);
})
A.b("asdas1", function() {
Math.floor(d) + Math.floor(d,e);
Math.max(e,d);
})
`
);

it("should collect and minify in segments in any depth if there is no LCA", () => {
const source = unpad(`
function b(){
thePlugin(
"should collect and minify in segments in any depth if there is no LCA",
`
function b(){
Math.floor(as, bb);
function d(){
Math.floor(as, bb);
function d(){
Math.floor(as, bb);
}
}
const a = {
c : () => Math.floor(bbb) + Math.floor(bbb) ,
d : () => {
Math.abs(aa);
Math.abs(aa);
}
const a = {
c : () => Math.floor(bbb) + Math.floor(bbb) ,
d : () => {
Math.abs(aa);
Math.abs(aa);
Math.floor(aa);
return () => {
Math.floor(aa);
return () => {
Math.floor(aa);
}
},
e : () => Math.abs(aa) + Math.abs(aa)
};
class A {
constructor() {
let a = Math.floor(b,c) + Math.floor(b,c);
}
c() {
Math.floor(asdas);
Math.floor(dasda);
}
d() {
var a = Math.floor;
a(aa, bb);
Math.floor(aa, bb);
}
};
new A()
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
}
},
e : () => Math.abs(aa) + Math.abs(aa)
};
class A {
constructor() {
let a = Math.floor(b,c) + Math.floor(b,c);
}
c() {
Math.floor(asdas);
Math.floor(dasda);
}
d() {
var a = Math.floor;
a(aa, bb);
Math.floor(aa, bb);
}
};
new A()
`
);

it("should evalaute expressions if applicable and optimize it", () => {
const source = unpad(`
const a = Math.max(Math.floor(2), 5);
let b = 1.8;
let x = Math.floor(Math.max(a, b));
foo(x);
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should evalaute expressions if applicable and optimize it",
`
const a = Math.max(Math.floor(2), 5);
let b = 1.8;
let x = Math.floor(Math.max(a, b));
foo(x);
`
);

it("should not evaluate if its side effecty", () => {
const source = unpad(`
Math.max(foo(), 1);
Math.random();
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should not evaluate if its side effecty",
`
Math.max(foo(), 1);
Math.random();
`
);

it("should not minify for computed properties", () => {
const source = unpad(`
let max = "floor";
Math[max](1.5);
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should not minify for computed properties",
`
let max = "floor";
Math[max](1.5);
`
);

it("should not minify for arrow fn without block statment", () => {
const source = unpad(`
const a = () => Math.floor(b) + Math.floor(b);
`);
expect({ _source: source, expected: transform(source) }).toMatchSnapshot();
});
thePlugin(
"should not minify for arrow fn without block statment",
`
const a = () => Math.floor(b) + Math.floor(b);
`
);
});
Loading