Conversation
boopathi
added
Tag: Breaking Change
|
Should it be Babel Minify, BabelMinify or Babel-Minify? |
|
babel-minify like babel-loader/babel-eslint, etc? |
| ```sh | ||
| $ git clone https://github.com/babel/babili | ||
| $ cd babili | ||
| $ git clone https://github.com/babel/minify |
There was a problem hiding this comment.
maybe this should be git clone https://github.com/babel/minify babel-minify? and need to change below too
| $ git clone https://github.com/babel/minify | ||
| $ cd minify | ||
| $ npm install | ||
| $ npm run bootstrap |
There was a problem hiding this comment.
aside: this should be npm run bootstrap which also runs yarn beforehand? don't need npm install since we are using yarn
| | [`babel-plugin-transform-remove-debugger`](/packages/babel-plugin-transform-remove-debugger) | [](https://www.npmjs.com/package/babel-plugin-transform-remove-debugger) | [](https://david-dm.org/babel/minify?path=packages/babel-plugin-transform-remove-debugger) | | ||
|
|
||
| ## Benchmarks | ||
|
|
There was a problem hiding this comment.
can change the benchmark names below too
hzoo
left a comment
hzoo
left a comment
There was a problem hiding this comment.
I'd rather use babel-minify instead of BabelMinify but we can change it later, feel free to merge now and do another pr
|
The hooks are not working now.. Need to fix it |
|
Will fix build after merge. And make the changes in docs after this merge. |
|
the README is now out of sync with npm. Both I assume the plan is for a new release to replace the old entries on npmjs, but until then this README is more than a little confusing. Perhaps add a temporary note stating that they can't be installed until the new package has been published on npm? |
|
Will release the new package. |
5 participants
HERE WE GO
#124