Skip to content

Improve comments support#674

Closed
boopathi wants to merge 1 commit intomasterfrom
comments-001
Closed

Improve comments support#674
boopathi wants to merge 1 commit intomasterfrom
comments-001

Conversation

@boopathi
Copy link
Copy Markdown
Member

Fix #668

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Aug 17, 2017
inputSourceMap,

shouldPrintComment(contents) {
return shouldPrintComment(contents, comments);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work right now. Looks like a babel bug ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we haven't upgraded babel version for quite sometime right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's a babel-generator option.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is. I'm not sure why this function is not called at all.

@vigneshshanmugam
Copy link
Copy Markdown
Member

Closing in favor of #855

@vigneshshanmugam vigneshshanmugam deleted the comments-001 branch May 17, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tag: Bug Fix Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants