Fix(merge-sibling-var): force recalc ref when concatenating for-loop vars (#485)

[garyyeap]

Fix #594
Fix #430
Fix #412
Fix #554
Fix #581
Fix #477
Fix #720
Fix #485

[garyyeap]

Not sure how to write test as some issues only occur when using mergeVars, deadcode or mangle at the same time

[boopathi]

Thanks a lot. I'll merge it with tests. You can add test cases in babel-preset-minify/__tests__

[boopathi]

next.replaceWith(t.variableDeclaration("var", declarations))

[boopathi]

Can you also fix this one? Use babel path API instead of mutating node.

[garyyeap]

Tried & failed with this way, the output eliminated the for-loop

[boopathi]

Oops. It's

init.replaceWith(t.variableDeclaration("var", declarations);

and init.remove() should be removed.

[garyyeap]

Done, thanks for correcting

[edmorley]

Hi!

This is breaking the build in mozilla/hawk#223 - I don't suppose a point release could be made that includes this fix? :-)

[boopathi]

@edmorley Every commit to master is released as a canary version - docs - https://github.com/babel/minify/tree/master/docs#canary-version ... But it's ONLY for ease of testing. Would not recommend using canary tag committed in your package.json.

[allanjackson]

I just want to chime in that this is also breaking our build, so we can't use babel-minify 0.2.0 right now. It would be great if we could get a non-canary release that includes this fix.

[vigneshshanmugam]

@allanjackson Its done. use 0.3.0

[allanjackson]

Thanks!