Merged
Conversation
Contributor
Author
|
Don't know why one test fails, I can't run them localy... |
Contributor
Author
|
@boopathi can you help me with the failing test? |
Contributor
|
Have you considered instead optimizing the regex like it is done currently, then running |
Contributor
|
Try running |
Contributor
Author
|
i‘ll try! thx! |
Contributor
Author
|
I thought about doing this, but I’ve not realy thought about what this module is doing, I only wanted to find what breaks. |
9c1cf88 to
bb91fc7
Compare
bb91fc7 to
7683e30
Compare
2707b33 to
f7103af
Compare
Contributor
Author
|
@j-f1 can you review? |
Contributor
Author
|
@boopathi failing tests now fixed, and unit test for functionality created! |
This was referenced Nov 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #732