Skip to content

fix(mangle) - mark the correct eval scope during mangling#763

Merged
boopathi merged 1 commit intomasterfrom
fix-366
Dec 19, 2017
Merged

fix(mangle) - mark the correct eval scope during mangling#763
boopathi merged 1 commit intomasterfrom
fix-366

Conversation

@vigneshshanmugam
Copy link
Copy Markdown
Member

We were always checking the wrong scope that was marked by DCE in another pass.

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Dec 19, 2017
`Unexpected Rename Error: ` +
`Trying to replace "${node.name}": from "${oldName}" to "${newName}". ` +
`Trying to replace "${
node.name
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe update prettier that's used in your editor? Also, is yarn fix changing this too ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn fix doesnt change this but changes some other things.. I have updated the editor prettier.. something weird.

@vigneshshanmugam
Copy link
Copy Markdown
Member Author

@boopathi restart appveyor build, some caching issue and add me there.

@boopathi
Copy link
Copy Markdown
Member

add me there

I can't find where to add. I'll check it.

@vigneshshanmugam
Copy link
Copy Markdown
Member Author

Omg appveyor, crazy slow. 7 mins and counting.

@boopathi boopathi merged commit a351eee into master Dec 19, 2017
@boopathi boopathi deleted the fix-366 branch December 19, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tag: Bug Fix Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deadcode erroneously mangling names wrt eval? babili is removing function arguments in scope of eval call

2 participants