Conversation
boopathi
reviewed
Jan 15, 2018
|
|
||
| if ( | ||
| !t.isAnyTypeAnnotation(leftTypes) && | ||
| t.isFlowBaseAnnotation(leftTypes) |
Member
There was a problem hiding this comment.
I'm not sure if this affects the babel-7 upgrade. I think we should test this against Babel7. What do you think?
Member
Author
There was a problem hiding this comment.
No it stays the same, No change for babel 7
boopathi
approved these changes
Jan 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the type information that is lost due to sequence expression transformation in Simplify plugin. It takes a different approach instead of traversing all of the identifiers for type information.
Before
After
The type inference is based on the Babel inference.