fix: update outdated react url#817
Merged
vigneshshanmugam merged 3 commits intobabel:masterfrom Apr 23, 2018
ganes1410:remove-outdated-url
Merged
fix: update outdated react url#817vigneshshanmugam merged 3 commits intobabel:masterfrom ganes1410:remove-outdated-url
vigneshshanmugam merged 3 commits intobabel:masterfrom
ganes1410:remove-outdated-url
Conversation
|
|
||
| const ASSETS_DIR = path.join(__dirname, "benchmark_cache"); | ||
| const DEFAULT_ASSETS = { | ||
| "react.js": "https://unpkg.com/react/dist/react.js", // 120 kb |
Member
There was a problem hiding this comment.
we would like to keep react as a dep here since we use it for smoke tests.
So please update with the new URL instead of removing it. You can find the relevant code here https://unpkg.com/react@16.3.1/
Contributor
Author
There was a problem hiding this comment.
@vigneshshanmugam should i update it with react.development.js or react.production.js ??
boopathi
changed the title
scripts/benchmark.js
Outdated
| const ASSETS_DIR = path.join(__dirname, "benchmark_cache"); | ||
| const DEFAULT_ASSETS = { | ||
| "react.js": "https://unpkg.com/react/dist/react.js", // 120 kb | ||
| "react.js":"https://unpkg.com/react@16.3.1/umd/react.development.js", |
Member
There was a problem hiding this comment.
- lint issue, add space before.
- add no of bytes at the end
Contributor
Author
There was a problem hiding this comment.
@vigneshshanmugam i made required changes.sorry for the delay
vigneshshanmugam
approved these changes
Apr 23, 2018
Member
|
Thanks @ganes1410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #816
The above image shows the script successfully running.