Skip to content

fix(const-folding): do not evaluate identifier in export specifiers #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boopathi merged 1 commit into from
May 2, 2018
Merged

fix(const-folding): do not evaluate identifier in export specifiers #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/babel-plugin-minify-constant-folding/__tests__/fixtures/export-specifier/actual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const a = "a";
const b = "b";
export { a, b };
3 changes: 3 additions & 0 deletions packages/babel-plugin-minify-constant-folding/__tests__/fixtures/export-specifier/babel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"sourceType": "module"
}
3 changes: 3 additions & 0 deletions ...ages/babel-plugin-minify-constant-folding/__tests__/fixtures/export-specifier/expected.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const a = "a";
const b = "b";
export { a, b };
7 changes: 6 additions & 1 deletion packages/babel-plugin-minify-constant-folding/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ module.exports = babel => {

// TODO: look into evaluating binding too (could result in more code, but gzip?)
Expression(path, { opts: { tdz = false } = {} }) {
const { node } = path;
const { node, parent } = path;

if (node[seen]) {
return;
Expand All @@ -116,6 +116,11 @@ module.exports = babel => {
return;
}

// Avoid replacing the values for identifiers in exports
if (t.isExportSpecifier(parent)) {
return;
}

// -0 maybe compared via dividing and then checking against -Infinity
// Also -X will always be -X.
if (
Expand Down