perf(builtins): run builtins transform on multi pass#859
Merged
Conversation
Member
vigneshshanmugam
commented
May 17, 2018
vigneshshanmugam
commented
- This improves the performance approximately from ~600ms to ~250ms on a 2mb file.
boopathi
approved these changes
May 17, 2018
Member
Author
|
I love where we have finally reached with the current set of optimisations. The average time went from ~600ms to ~80ms on a 2mb test file. |
Member
Author
|
For Lodash, we went from approx 100ms to 12ms. But out of it, 60-70ms was from path traversal context creation which is fixed through multi pass. |
This was referenced Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.