Skip to content

Rcpp: Replace arma::is_finite() with std::isfinite() #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pschil merged 1 commit into from
Sep 21, 2025
Merged

Rcpp: Replace arma::is_finite() with std::isfinite() #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/pnbd_dyncov_LL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "pnbd_dyncov_LL.h"

void Customer::set_real_walk_life(const arma::vec& adj_covdata_real_life, const arma::rowvec& walkinfo_real_life){
if(arma::is_finite(walkinfo_real_life(0)) && arma::is_finite(walkinfo_real_life(1))){
if(std::isfinite(walkinfo_real_life(0)) && std::isfinite(walkinfo_real_life(1))){
this->real_walk_life = LifetimeWalk(adj_covdata_real_life, walkinfo_real_life);
}else{
this->real_walk_life = EmptyLifetimeWalk();
Expand Down Expand Up @@ -570,7 +570,7 @@ double pnbd_dyncov_LL_i_F2_3(const double r, const double alpha_0, const double
}

// abort immediately, do not waste more loops
if(!arma::is_finite(F2_3)){
if(!std::isfinite(F2_3)){
return(F2_3);
}
}
Expand Down Expand Up @@ -666,7 +666,7 @@ double pnbd_dyncov_LL_i_F2(const double r, const double alpha_0, const double s,
a1, b1,
A1T, C1T);
intermediate_results(9) = F2_1;
if(!arma::is_finite(F2_1)){
if(!std::isfinite(F2_1)){
return(F2_1);
}

Expand All @@ -676,7 +676,7 @@ double pnbd_dyncov_LL_i_F2(const double r, const double alpha_0, const double s,
aT, bT,
AkT, CkT);
intermediate_results(10) = F2_2;
if(!arma::is_finite(F2_2)){
if(!std::isfinite(F2_2)){
return(F2_2);
}

Expand Down Expand Up @@ -820,7 +820,7 @@ Rcpp::NumericVector pnbd_dyncov_LL_i(const double r, const double alpha_0, const
// advantage of the much simpler case F2==0 because also very small abs(F2) are really relevant for correct results!
//
double LL = 0;
if(!arma::is_finite(F2)){
if(!std::isfinite(F2)){
LL = F2;
}else{

Expand Down Expand Up @@ -1001,7 +1001,7 @@ Rcpp::NumericMatrix pnbd_dyncov_LL_ind(const arma::vec& params,

// Check whether customer has real trans walks
// Could also check x==0, but saver to look at actual content
if(arma::is_finite(walkinfo_trans_real_from(i))){
if(std::isfinite(walkinfo_trans_real_from(i))){

// Repeat customer (with real trans walks)
arma::uword wi_real_trans_from = static_cast<arma::uword>(walkinfo_trans_real_from(i)) - 1;
Expand Down
Loading