Merged
Conversation
* Fix wrongly named and wrongly placed variables
As they are by definition always >0 and assessing their significance is pointless
* rename `predicted.total.spending` -> `predicted.period.spending` * rename `actual.total.spending` -> `actual.period.spending`
Ad-hoc implementation, refactoring advised
* Use `clv.get.LL` within `hessian()` * Tests: Test `hessian()` with more and combined specifications * Tests: Internal `clv.fitted.get.LL`
Such that `data.end` > last transaction AND `estimation.split` < last transaction -> Therefore, also `estimation.split` < `data.end` -> This is to guarantee that the holdout period always contains at least 1 transaction * clv.time: set.sample.periods(data.end) * summary.clv.data: Print start and end of periods * clvdata(): Add `data.end` * Tracking plot (clv.data & clv.fitted): Plot empty dates and leave NAs in the data * Tests: New and adapt existing
* Originals are on overleaf * Add R.rsp as vignette builder * Add vignettes: advanced techniques, intuitive explanations, classes * UML class overview for vignette
* Produces NOTES on CRAN * As advised in warning message
Otherwise produces cran note
* Compact, otherwise produces cran note
* Use `tools::compactPDF("./vignettes/xxx.pdf", gs_quality = "printer")`
* Compact pdfs manually as Rstudio build options are not respected when using `devtools` directly. Would need to pass as `args` to devtools what is cumbersome and easily forgotten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.