footnotes_views: Fix PHP notices

[olafgrabienski]

Testing the submodule, I've noticed a lot of PHP notices in DBlog:

• Warning: Parameter 3 to views_ui_build_form_state() expected to be a reference, value given in views_ui_ajax_form() (line 2871 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: form_key in views_ui_build_form_path() (line 2748 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: view in views_ui_build_form_path() (line 2750 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Trying to get property of non-object in views_ui_build_form_path() (line 2750 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: form_key in views_ui_build_form_path() (line 2751 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: display_id in views_ui_build_form_path() (line 2751 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: args in views_ui_build_form_path() (line 2752 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Warning: Invalid argument supplied for foreach() in views_ui_build_form_path() (line 2752 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: form_id in views_ui_ajax_form() (line 2877 of /(...)/core/modules/views_ui/views_ui.admin.inc).
• Notice: Undefined index: in backdrop_retrieve_form() (line 814 of /(...)/core/includes/form.inc).
• Warning: call_user_func_array() expects parameter 1 to be a valid callback, no array or string given in backdrop_retrieve_form() (line 858 of /(...)/core/includes/form.inc).
• Theme hook "" not found.
  • Location: /admin/structure/views/ajax/config-item/my_test_view/default/field/teaser_content
  • Referrer: /admin/structure/views/view/my_test_view

[olafgrabienski]

I'll repeat the test in a clean installation and will then also provide the PHP version.

[olafgrabienski]

I've tested the Footnotes Views submodule again in a quite fresh Backdrop site (PHP version 7.1.12), adding the fields Node: Body content and Node: Body footnotes to a view.

The view works, but I found some messages in the DBlog:

Warning: Declaration of footnotes_views_handler_field_body_content::init(&$view, $options) should be compatible with views_handler_field_entity::init(&$view, &$options) in require_once() (line 8 of (...)/modules/footnotes-1.x-1.x/footnotes_views/views/footnotes_views_handler_field_body_content.inc).

Warning: Declaration of footnotes_views_handler_field_body_footnotes::init(&$view, $options) should be compatible with views_handler_field_entity::init(&$view, &$options) in require_once() (line 3960 of (...)/core/includes/bootstrap.inc).

Warning: Parameter 3 to views_ui_build_form_state() expected to be a reference, value given in views_ui_ajax_form() (line 2871 of (...)/core/modules/views_ui/views_ui.admin.inc).

There are however less messages than originally reported in the issue description. I guess partly because I didn't test the teaser field - there's a separate issue about it. Hope this helps to isolate the reason for the messages.

[olafgrabienski]

Removing the "release blocker" tag because the basics of the Views integration work, even with the warnings, hoping that people who need Views integration will help to fix the issue.