Skip to content

Conversation

@samiramkr
Copy link
Contributor

@samiramkr samiramkr commented Nov 17, 2020

This plugin uses an integrationKey is annotated to an entity and based on this integrationKey it is going to show the list of incidents and on calls for this service. Through this plugin user can trigger an alarm by providing a description. Also user can send an email to on call people by clicking on people's name or envelop icon. There is also a link to pagerduty page. When there is not any incident, it is going to show an emptyState. The token is mandatory for pagerduty plugin, proxy has been used for adding the token, if the token has not been provided or is invalid, the missing token emptyState is going to be shown to user.

We are raising this as a draft PR to get some feedbacks on it and there is still some little works to do.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

When the token has not been injected:

Screenshot 2020-11-17 at 11 15 27

The pagerduty:

Screenshot 2020-12-04 at 11 27 15

The triggerAlarm dialog:

Screenshot 2020-12-04 at 11 26 40

When there is no incident:

Screenshot 2020-12-04 at 11 26 29

@benjdlambert
Copy link
Member

A have a question about the pagerduty logo - does it need to be added to the NOTICE file and does it have the right license?

Copy link
Collaborator

@andrewthauer andrewthauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Few more minor comments around consistency. I added some more specific examples on a couple areas that maybe were not completely clear.

@benjdlambert
Copy link
Member

Just a friendly reminder about this comment

A have a question about the pagerduty logo - does it need to be added to the NOTICE file and does it have the right license?

@samiramkr samiramkr closed this Nov 30, 2020
@samiramkr samiramkr reopened this Nov 30, 2020
@samiramkr
Copy link
Contributor Author

Just a friendly reminder about this comment

A have a question about the pagerduty logo - does it need to be added to the NOTICE file and does it have the right license?

The pagerduty logo replaced by an appropriate icon.

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to get this through! 🥳

Copy link
Contributor

@stefanalund stefanalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add it to the Marketplace! 👍

@samiramkr samiramkr merged commit f3b24a9 into master Dec 4, 2020
@samiramkr samiramkr deleted the samiram/pagerduty-plugin branch December 4, 2020 16:02
@Rugvip Rugvip mentioned this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants