Skip to content

Conversation

@LitoMore
Copy link
Member

@LitoMore LitoMore commented Nov 16, 2025

Resolves #11071

This PR adds Node.js 24 to the engines and check-node-version list. But we are still using Node.js 22 for running GitHub Actions. We can switch to Node.js by creating another PR when we feel ready.

This PR also reverted the eslint-config-prettier change from #11432. npm has fixed a peer dependencies issue since npm/cli#8579. We need to bring the eslint-config-prettier back because the eslint-config-prettier is the peer dependency of eslint-plugin-prettier.

Note:
We already have an issue to track the npm run docusaurus:start failing issue. And it should have nothing to do with the Node.js version:

@socket-security
Copy link

socket-security bot commented Nov 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedemojic@​1.1.181001009779100

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @LitoMore!

Generated by 🚫 dangerJS against 6229202

@LitoMore

This comment was marked as outdated.

@PyvesB PyvesB added the operations Hosting, monitoring, and reliability for the production badge servers label Nov 16, 2025
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @LitoMore! Looks good to me. 👍🏻

@PyvesB PyvesB added this pull request to the merge queue Nov 16, 2025
Merged via the queue into badges:master with commit fe18dc7 Nov 16, 2025
21 checks passed
@LitoMore LitoMore deleted the allow-node-24 branch November 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

operations Hosting, monitoring, and reliability for the production badge servers

Development

Successfully merging this pull request may close these issues.

Allow shields to run on node 24

2 participants