Use Alt instead of pure Flux#28
Open
stukennedy wants to merge 11 commits intobadsyntax:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alt allows huge simplification of the stores, actions, no need for constants and also how components respond to Store events.
I've removed BaseStore and the test for it, as none of the features in the seed required this level of abstraction, and I think as a starting point could be a bit confusing ... but open to negotiation on that one.
As I mentioned in my Issue #27, if this is not something you want, I understand and I'll just keep it on my own fork ... but wondered it this might be a welcome adaptation to your already excellent seed.