-
Notifications
You must be signed in to change notification settings - Fork 7
(feat) xseed.sh: Add multiple download client support #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zakkarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have any questions, I sort of rushed this a bit, but you should understand what I've suggested.
zakkarry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secondary review that refactors the is valid client function....
Co-authored-by: zakary <zak@ary.dev>
Co-authored-by: zakary <zak@ary.dev>
Co-authored-by: bakerboy448 <55419169+bakerboy448@users.noreply.github.com>
Co-authored-by: zakary <zak@ary.dev>
Co-authored-by: zakary <zak@ary.dev>
Co-authored-by: zakary <zak@ary.dev>
|
@zakkarry @bakerboy448 thank you both so much for your review!! I didn't mean to create extra work, but I do appreciate the thorough feedback and refactor. I'll do my best to keep those patterns in mind for any future contributions. |
Co-authored-by: zakary <zak@ary.dev> Update xseed.sh Co-authored-by: zakary <zak@ary.dev>
Update xseed.sh Update xseed.sh Update xseed.sh Co-Authored-By: zakary <zak@ary.dev>
|
so, i did some pretty big cleanup on your commit history since you just applied suggestions from the page i think.... also instead of a merge i rebased for you. also changed how env vars were handled a bit and the config section, but it should function correctly. if you can try it out and let me know if you run into any issues i'd appreciate it. |
pending testing
Co-authored-by: bakerboy448 <55419169+bakerboy448@users.noreply.github.com>
…rrScripts into starr-multi-client
|
Sometimes I wonder what business I think I have touching code at all :) Thank you so much for cleaning up my mess. I've confirmed the modifications work great on my end: 2024-11-18 10:57:45 [INFO] Environment variables loaded successfully
2024-11-18 10:57:45 [DEBUG] Using '.env' file for config?: true
2024-11-18 10:57:45 [INFO] Using Configuration:
2024-11-18 10:57:45 [INFO] TORRENT_CLIENTS="qBittorrent" "qBittorrent (Anime)"
2024-11-18 10:57:45 [INFO] USENET_CLIENTS="SABnzbd" "SABnzbd (Anime)"
2024-11-18 10:57:45 [INFO] XSEED_HOST=(IP)
2024-11-18 10:57:45 [INFO] XSEED_PORT=2468
2024-11-18 10:57:45 [INFO] LOG_FILE=(PATH)/xseed_db.log
2024-11-18 10:57:45 [INFO] LOGID_FILE=(PATH)/xseed-id.log
2024-11-18 10:57:45 [INFO] Detected application: sonarr
2024-11-18 10:57:45 [INFO] Processing torrent client operations for qBittorrent (Anime)...
2024-11-18 10:58:09 [INFO] Cross-seed API response: 204
2024-11-18 10:58:09 [INFO] Process completed successfully. |
I wouldn't go that far. Appreciate the effort either way. |
I (and perhaps others?) use granular settings on the *arr side to send downloads to different client profiles, each with their own category/download folder/etc., which takes some burden off individual clients for supporting various features on their end. This PR:
.env.samplewith comments and examples (and also adds$LOGID_FILE, which might have been missing from (feat) xseed.sh: add LOGID_FILE to track downloaded ids #24)Granular changes:
.env):$[TORRENT|USENET]_CLIENT_NAME->$[TORRENT|USENET]_CLIENTScasestatements with a validation function (is_valid_client) andif/elif)Feel free to discard this if it's outside what you wish for the script, I just made the modifications for my own setup and thought I'd give back :)