Skip to content

Conversation

@craigvantonder
Copy link

@craigvantonder craigvantonder commented Jun 16, 2024

Incorporates PR-131 whilst adding another change that I ran into when testing with socket.io-client@4.7.5

Tried to get the tests to pass but it seems there is an issue, atleast on my system, with phantomjs. So I worked around that and ran into another test issue where it fails on queueing -> requests -> after reconnecting socket

1) queueing ::  requests ::  after reconnecting, socket should execute queued requests successfully:
     Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
      at listOnTimeout (node:internal/timers:569:17)
      at process.processTimers (node:internal/timers:512:7)

I tried to bump to the latest Sails version in package.json (not included in PR) but this seems to give the same issue as above.

Tested this out on with a sails new application and the client reconnects to the server when it stop/starts so it seems to be working fine. I am assuming that this test error has something to do with server side and within the test code or app setup within. Not sure.

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/sails-hook-sockets@3.0.0 environment Transitive: eval, filesystem, network +40 8.74 MB eashaw
npm/sails@1.5.11 Transitive: environment, eval, filesystem, network, shell, unsafe +218 15 MB
npm/socket.io-client@4.7.5 Transitive: environment, filesystem, network, shell +8 2.4 MB darrachequesne

🚮 Removed packages: npm/sails-hook-sockets@1.5.5, npm/sails@1.5.10, npm/socket.io-client@2.0.3

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant