Open
Conversation
added 11 commits
January 7, 2016 11:04
Author
There was a problem hiding this comment.
I'm not sure the function is necessary, you're not reusing it so line 20 can just be on it's own.
Author
|
@hrousley feedback is in. Overall this looks great, nice job 👍 . The only thing that really bothers me if you either should have went all in with jquery or tried to do completely without. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hrousley I wanted to do a pr will all the current code, so I rebased the repo with an empty commit at the root, made a branch from it and created a pr.