Added config to CCXT feed parameters#3
Closed
rmihael wants to merge 4 commits into
Closed
Conversation
Owner
|
What's the point of using sandbox for public API? From my point of view it only makes sense to do for private/broker API, no? |
Author
|
It makes sense for backtesting validation. In one run I want to run my strategy against sandbox (both feed and orders) and in another run -- against BackBroker with historical data strictly matching previous sandboxed run. |
Owner
|
Thanks for the explanations. That makes sense to me now. Can we make this parameter optional? |
Author
|
Sure, why not. I'll update PR. |
bartosh
pushed a commit
that referenced
this pull request
Dec 23, 2017
Owner
|
closed by cb921c2 |
bartosh
pushed a commit
that referenced
this pull request
Feb 3, 2018
JustinHop
pushed a commit
to JustinHop/backtrader
that referenced
this pull request
Feb 15, 2018
bartosh
pushed a commit
that referenced
this pull request
Feb 27, 2018
bartosh
pushed a commit
that referenced
this pull request
Mar 18, 2018
bartosh
pushed a commit
that referenced
this pull request
Jun 16, 2018
bartosh
pushed a commit
that referenced
this pull request
Aug 5, 2018
bartosh
pushed a commit
that referenced
this pull request
Sep 9, 2018
cbinners
pushed a commit
to cbinners/backtrader
that referenced
this pull request
Jun 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's worth adding the config parameter to the feed class as well. Otherwise when trying to use sandbox broker is instantiated with a proper endpoint and feed still uses real environment.
This change is