Skip to content

Conversation

@Snezhkko
Copy link
Contributor

Reason: With set -u, referencing unset variables in conditions (e.g., [[ -z "$RETH_CHAIN" ]] and checking RETH_FB_WEBSOCKET_URL) causes an “unbound variable” error, terminating the script unexpectedly.
Change: Updated conditional checks to use safe expansion ${RETH_CHAIN:-} and ${RETH_FB_WEBSOCKET_URL:-}.
Goal: Prevent crashes when optional env vars are unset while preserving existing behavior when they are provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 14, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@danyalprout danyalprout merged commit 86e563a into base:main Oct 9, 2025
1 check passed
@Tuniex01
Copy link

Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants