-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(reth_entrypoint): add flashblocks to additional args instead of rewritting #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reth_entrypoint): add flashblocks to additional args instead of rewritting #646
Conversation
✅ Heimdall Review Status
|
|
This seems good. Could you rebase? |
…ewritting, add explicit echo for additional arguments
5e4a48a to
6cff9fc
Compare
Done, thanks |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hey @haardikk21 let's merge it if everything okay or it will closed by your github CI actions 🌝 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bulliah |
Today I found an issue with additional args in reth entrypoint, one of my args want propagate to the reth.
I've checked the code and found the root cause,
ADDITIONAL_ARGS="--websocket-url=$RETH_FB_WEBSOCKET_URL"is completely rewriting the ADDITIONAL_ARGS value.Funny, that pruning agrs don't have this issue
What was done: