Use per-tx execution time sum on bundle detail page#156
Merged
Conversation
Same fix as the block page: use sum of results[i].executionTimeUs instead of totalExecutionTimeUs, which on 0.6 includes setup, teardown, and state root overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sum(results[i].executionTimeUs)instead oftotalExecutionTimeUson the bundle detail pagetotalExecutionTimeUsis the wall-clocktotal_time_uswhich includes builder setup, teardown, state merge, and state root — making the "Execution" number inflated and inconsistent with the block pageContext
Companion to #155. Without this, the bundle detail page shows a higher execution time than the block page for the same transaction.