feat: more audit events for tx inclusion and backrun#98
Closed
cody-wang-cb wants to merge 7 commits intomasterfrom
Closed
feat: more audit events for tx inclusion and backrun#98cody-wang-cb wants to merge 7 commits intomasterfrom
cody-wang-cb wants to merge 7 commits intomasterfrom
Conversation
cody-wang-cb
changed the title
wlawt
reviewed
Dec 16, 2025
| timestamp: i64, | ||
| reason: DropReason, | ||
| }, | ||
| TransactionReceived { |
Contributor
There was a problem hiding this comment.
is it worth documenting the expected audit lifecycle of a transaction/backrun bundle?
Comment on lines
+184
to
+185
| backrun_rx: broadcast::Receiver<(tips_core::Bundle, uuid::Uuid)>, | ||
| tx_bundle_id_rx: broadcast::Receiver<(TxHash, uuid::Uuid)>, |
Contributor
There was a problem hiding this comment.
i might be missing something, but is it possible to only keep backrun_rx?
my thinking is that tips_core::Bundle contains a txs field which is a Vec<Bytes>
if we were to do that then we'd probably need an enum/flag to decide on which base_ RPC call to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For backrun bundles execution, it's critical to track times at individual component, thus updated more events to track the entire transaction executing lifecycle as well as for backrun bundles.