Strip symbol/debugging info from production builds#42
Merged
kevinmcconnell merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Go linker flags used by the Makefile to strip symbol and DWARF debugging information from the produced binaries, reducing artifact size.
Changes:
- Add
-s -wto thego build-ldflagsused by Make targets (viaLDFLAGS).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ARCHITECTURES = amd64 arm64 | ||
| VERSION := $(shell git describe --tags --always) | ||
| LDFLAGS := -ldflags "-X 'github.com/basecamp/once/internal/version.Version=$(VERSION)'" | ||
| LDFLAGS := -ldflags "-s -w -X 'github.com/basecamp/once/internal/version.Version=$(VERSION)'" |
There was a problem hiding this comment.
The PR title says this is for “production builds”, but LDFLAGS is used by both make build (also run in CI) and make dist/build-all, so -s -w will apply to all builds (including local dev builds). Consider scoping the stripped flags to the release targets (e.g., a separate RELEASE_LDFLAGS used only by build-all/dist, or a STRIP ?= 0/1 toggle), or update the PR title to match the behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.