Conversation
When the UI is open in one terminal, and teardown is triggered from another, the UI panics and crashes. This is due to the ScrollToSelection function which resolves the current Panel to nil and then tries to call Height on it. Fixes: #49
monorkin
force-pushed
the
fix-ui-crash-on-teardown
branch
from
0b13eab to
c640ed5
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a TUI panic when once teardown is triggered in another shell by preventing scrollToSelection() from indexing into an empty panels slice (reported in #49).
Changes:
- Add an early return in
Dashboard.scrollToSelection()when there are no panels, avoiding an out-of-range access.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the UI is open in one terminal, and teardown is triggered from another, the UI panics and crashes. This is due to the ScrollToSelection function which resolves the current Panel to nil and then tries to call Height on it.
Fixes: #49