This repository was archived by the owner on May 26, 2020. It is now read-only.
Base fixes#2
Open
michalbugno wants to merge 11 commits intomasterfrom
Open
Conversation
Otherwise, if multiple focus traps are used, returnFocus will return focus to the previous trap, but it's unpausing will reset focus to the first item.
FocusTrap is perfectly legit in scenarios without focusable elements - like temporarily disabled modal.
Enables focus trap in complex layouts with popovers, where visually connected elements are actually siblings
|
If you want to release it, you need to create a new version. Run in the console in focus-trap folder: And then you can install this version in the base app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a branch that should be used when using this repo (vs detached commits until now) + cherry picks focus-trap@68c82d8
@panrafal There are other commits but I don't feel like I could do a sensible rebase there (it's not straightforward), maybe it's worth your time? (probably few minutes ;d)