Skip to content

Conversation

@joedevivo
Copy link
Contributor

This function was supposed to be a convenience function for schema writers that wrapped proplists:get_value

It only makes sense to have the arty 3 version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simplify this by having the 2-arity version call the 3-arity version with the third argument of undefined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, that almost seems "too" correct. will do.

@seancribbs
Copy link

Dialyzed this, found some bugs. These are not part of the PR, but should be addressed soon. Ideally rebar would be added to the PLT to resolve the mustache/rebar problems, but I'm not quite sure how to do that without making rebar a dependency.

Unknown functions:
  eunit:test/1
  inti:stop/1
  mustache:render/2
  rebar_rel_utils:get_target_dir/2
  rebar_rel_utils:is_rel_dir/0
  rebar_rel_utils:load_config/2
$ ack "inti:stop" src
src/cuttlefish_escript.erl
105:            inti:stop(1);

@seancribbs
Copy link

Disregard the inti:stop error, it is not present on develop.

Rest of this is 👍 to merge.

joedevivo added a commit that referenced this pull request Oct 10, 2013
added cuttlefish_util:conf_get_value/3
@joedevivo joedevivo merged commit 9a21f72 into develop Oct 10, 2013
@joedevivo joedevivo deleted the jd-test-tools branch November 5, 2013 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants