-
Notifications
You must be signed in to change notification settings - Fork 157
Ready: TTB TS Support #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pberrorresp(encoding).
…etch operations to avoid double conversion from PB->TTB
…-connection/channel basis
|
@alexmoore - this depends on the https://github.com/basho/riak_pb/blob/riak_ts-develop/src/riak_pb_messages.csv#L70 I'm assuming |
|
@lukebakken Yes, it will be tagged appropriately. For now you can build and install it locally with @javajolt Have we tagged the PB changes yet for TS 1.3? |
|
Moving the Java stuff out of |
Build entire message with msg length and code 141
|
|
||
| if (isLastRow) | ||
| { | ||
| is.read_nil(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be moved after the for loop in parseRows. The isLastRow parameter wouldn't be necessary then.
|
@lukebakken I've got everything in ITestTimeSeries.java running now except for Riak sends me back I'll look into with another client Monday, unless you're doing odd-time work again :) |
|
One TS test should fail due to a server change, but this is ready for code review. |
Remove git artifact (.orig file)
|
@alexmoore - do you want me to address the TODOs? |
|
+1 👍 |
…java-client into perf/ttb_encoding/v3
Moving away from a PB backed cell to a more pure implementation.
No description provided.