Skip to content

Conversation

@alexmoore
Copy link
Contributor

No description provided.

@lukebakken lukebakken self-assigned this Apr 18, 2016
@lukebakken lukebakken changed the title Not Ready: TTB TS Support WIP: TTB TS Support Apr 18, 2016
@lukebakken
Copy link
Contributor

@alexmoore - this depends on the riak_ts-develop branch of riak_pb, specifically this line in the CSV:

https://github.com/basho/riak_pb/blob/riak_ts-develop/src/riak_pb_messages.csv#L70

I'm assuming riak_pb will be tagged appropriately.

@alexmoore
Copy link
Contributor Author

@lukebakken Yes, it will be tagged appropriately. For now you can build and install it locally with mvn clean install from the riak_pb base dir. If we have time I'd love to move that out as well.

@javajolt Have we tagged the PB changes yet for TS 1.3?

@lukebakken
Copy link
Contributor

Moving the Java stuff out of riak_pb will be in future PRs.


if (isLastRow)
{
is.read_nil();
Copy link
Contributor

@lukebakken lukebakken Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved after the for loop in parseRows. The isLastRow parameter wouldn't be necessary then.

@alexmoore
Copy link
Contributor Author

@lukebakken I've got everything in ITestTimeSeries.java running now except for test_i_TestThatNullsAreSavedAndFetchedCorrectly().

Riak sends me back {tsqueryresp,{[],[],[]}}, which is incorrect. It should send back 1 column (temperature, double type), with 1 row containing 1 null cell.

I'll look into with another client Monday, unless you're doing odd-time work again :)

@alexmoore alexmoore changed the title WIP: TTB TS Support Ready: TTB TS Support Apr 25, 2016
@alexmoore
Copy link
Contributor Author

One TS test should fail due to a server change, but this is ready for code review.

Failed tests:
  ITestTimeSeries.test_i_TestThatNullsAreSavedAndFetchedCorrectly:223 expected:<1> but was:<0>

@lukebakken
Copy link
Contributor

@alexmoore - do you want me to address the TODOs?

@lukebakken
Copy link
Contributor

+1 👍

@alexmoore alexmoore merged commit a9a71c9 into develop May 6, 2016
@alexmoore alexmoore deleted the perf/ttb_encoding/v3 branch May 24, 2016 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants