Skip to content

Conversation

@srgg
Copy link
Contributor

@srgg srgg commented Apr 19, 2016

Ready for review

srgg and others added 30 commits April 13, 2016 18:36
…ntroduce workaround for Full Bucket Reads without providing any keys
```
git clone https://github.com/basho/riak_pb
git checkout java-2.1.1.0
git checkout 2.1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We include riak_pb as a submodule now, so we can remove this step once that develop is merged back to this branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase from the latest develop, that should resolve this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srgg I have a branch that does that - There were some changes to the TSQuery command since we switched to term-to-binary support. https://github.com/basho/riak-java-client/tree/merge-dpclient-ts1.3

We need a test around using a coverage context with a TS query request. I need to see if I wrote this line correctly:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to add a test similar to this one, that adds a context, to make sure it encodes correctly: https://github.com/basho/riak-java-client/blob/merge-dpclient-ts1.3/src/test/java/com/basho/riak/client/core/codec/TermToBinaryCodecTest.java#L133

I think I added everything else in that branch to add the coverage context to the TTB TS Queries though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging1.3 branch into this one, @aleksey-suprun can prove this conversion by running (or extending, if needed) our Full Bucket Read Test

@alexmoore
Copy link
Contributor

Only other feedback is to use adjust the formatting for braces to be on a new line by themselves, to match the rest of the codebase:

if (blah)
{
    foobar();
}
else
{
    fuzzy();
}

I should probably document our "standard" somewhere :)

@alexmoore
Copy link
Contributor

alexmoore commented May 19, 2016

Just to document the list of everything:

srgg and others added 2 commits June 13, 2016 13:22
Merge the changes we did for TS 1.3 into dpclient branch, before merging back to develop.
@alexmoore
Copy link
Contributor

Thank you @srgg and @aleksey-suprun!

@srgg srgg mentioned this pull request Jul 20, 2016
8 tasks
@srgg
Copy link
Contributor Author

srgg commented Jul 20, 2016

@srgg srgg closed this Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants