-
Notifications
You must be signed in to change notification settings - Fork 157
Ready: Fix Null Pointer exception in #656. #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready: Fix Null Pointer exception in #656. #659
Conversation
| latch.await(); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up on line 331 above, there's another call to await with a timeout. This is the only place I can find left in the code (there are a few in the tests too) that calls await with a timeout but ignores the return value. Because it checks isDone afterwards, ignoring the return value does seem OK, though perhaps a comment would help.
For what it's worth, the test code ignores the return value here:
…per converting null string to BinaryValue in BinIndexQuery.java
|
@srgg Getting 2 errors with the latest commits: I think we still need the bucket name provided in the |
|
We can't let the match value be |
Fixes Null Pointer exception for #656, do some cleanup surrounding $bucket & $key indices.