Skip to content

Rewrite block logic to ViewModel #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsvetan-basic-rum merged 1 commit into from
Aug 2, 2025
Merged

Rewrite block logic to ViewModel #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 0 additions & 64 deletions Block/Footer.php
View file
Open in desktop

This file was deleted.

42 changes: 42 additions & 0 deletions ViewModel/Footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php declare(strict_types=1);

namespace BasicRum\Analytics\ViewModel;

use BasicRum\Analytics\Api\PageTypeDetectorInterface;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\View\Element\Block\ArgumentInterface;
use Magento\Store\Model\ScopeInterface;

class Footer implements ArgumentInterface
{
public function __construct(
private PageTypeDetectorInterface $pageTypeDetector,
private ScopeConfigInterface $scopeConfig
) {
}

/**
* Get module configuration
*/
public function getConfig(): array
{
// If you already have a getConfig method, keep its implementation
// and add to it if needed
$config = [
'beacon_endpoint' => $this->scopeConfig->getValue(
'basicrum/general/beacon_endpoint',
ScopeInterface::SCOPE_STORE
)
];

return $config;
}

/**
* Get the current page type
*/
public function getPageType(): string
{
return $this->pageTypeDetector->getPageType();
}
}
8 changes: 6 additions & 2 deletions view/frontend/layout/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@
xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
<body>
<referenceContainer name="before.body.end">
<block class="BasicRum\Analytics\Block\Footer" name="basicrum.analytics.footer"
<block name="basicrum.analytics.footer"
template="BasicRum_Analytics::footer.phtml"
ifconfig="basicrum/general/enabled"
/>
>
<arguments>
<argument name="view_model" xsi:type="object">BasicRum\Analytics\ViewModel\Footer</argument>
</arguments>
</block>
</referenceContainer>
</body>
</page>
22 changes: 16 additions & 6 deletions view/frontend/templates/footer.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
<?php
/** @var \BasicRum\Analytics\Block\Footer $block */
/** @var \Magento\Framework\View\Element\Template\RendererInterface $secureRenderer */
declare(strict_types=1);

$config = $block->getConfig();
$pageType = $block->getPageType();
use BasicRum\Analytics\ViewModel\Footer;
use Magento\Framework\Escaper;
use Magento\Framework\View\Element\Template;
use Magento\Framework\View\Helper\SecureHtmlRenderer;

/** @var Template $block */
/** @var Footer $viewModel */
/** @var SecureHtmlRenderer $secureRenderer */
/** @var Escaper $escaper */

$viewModel = $block->getViewModel();
$config = $viewModel->getConfig();
$pageType = $viewModel->getPageType();

$scriptString = <<<script
(function(w) {
Expand Down Expand Up @@ -58,9 +68,9 @@ $scriptString = <<<script
var js = d.createElement(s),
sc = d.getElementsByTagName(s)[0];

js.src="{$block->escapeJs($block->getViewFileUrl('BasicRum_Analytics::js/boomr/boomerang-1.815.60.cutting-edge.min.js'))}";
js.src="{$escaper->escapeJs($block->getViewFileUrl('BasicRum_Analytics::js/boomr/boomerang-1.815.60.cutting-edge.min.js'))}";
sc.parentNode.insertBefore(js, sc);
}(document, "script"));
script;
?>
<?= /* @noEscape */ $secureRenderer->renderTag('script', [], $scriptString, false) ?>
<?= /* @noEscape */ $secureRenderer->renderTag('script', [], $scriptString, false) ?>