Conversation
Add option to specify axes parent Add option to not output handles if not requested
bastibe
left a comment
bastibe
left a comment
There was a problem hiding this comment.
Thank you for your pull request! I like it!
However, there are a few questions I would like to be addressed before merging. Could you comment on them?
| end | ||
|
|
||
| if nargout > 0 | ||
| varargout{1} = violins; |
There was a problem hiding this comment.
Sometimes I run the function from the command line, and I don't want any output. This gives it the flexibility for that option in addition to the default output.
There was a problem hiding this comment.
That doesn't make sense to me. If you don't assign the return value, you don't receive it. Please revert this part of the change before merging.
There was a problem hiding this comment.
That was the point of this change. When I am running the function from the command line, sometimes I do not want to receive the return value.
There was a problem hiding this comment.
Please revert this change. If you do not want to receive the return value, put a semicolon at the end of the line.
| obj.ShowData = args.ShowData; | ||
| obj.ShowNotches = args.ShowNotches; | ||
| obj.ShowMean = args.ShowMean; | ||
| uistack(obj.ViolinPlot,'bottom'); |
There was a problem hiding this comment.
Why is the violin plot stacked to the bottom? I think I would generally expect the last plot to end up on top.
There was a problem hiding this comment.
It's mainly to help with selecting the scatter points using the data cursor or the select tool in the figure panel. With the violin plot on top, I can only select the violin plot and it is rather annoying to select the underlying scatter points.
There was a problem hiding this comment.
Then we should change the plot order and plot the scatter points last. But stacking the Violin to the bottom is counterintuitive and might break plots.
There was a problem hiding this comment.
Plot order is more of a visual feature, unless I am mistaken and you use the plot order for another function? I do not think it is that counterintuitive to stack Violin to the bottom using uistack since that is the purpose of that function.
There was a problem hiding this comment.
Imagine someone plotting first a few lines, then a Violin. The Violin should definitely be atop the lines. We can not mess with uistack.
2 participants
Add option to specify axes parent
Add option to not output handles if not requested