Skip to content

Made changes to CMakeLists.txt to work with Python3 and Python2 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatwolf merged 2 commits into from
Jul 19, 2024
Merged

Made changes to CMakeLists.txt to work with Python3 and Python2 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c0ccd
modified cmake build to pick python3 if available else pick python2
sudheerhebbale Jul 11, 2024
f875b16
Changed minimum cmake version to 3.12
sudheerhebbale Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 29 additions & 31 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,29 @@
cmake_minimum_required(VERSION 3.0.0)

set(CMAKE_BUILD_TYPE_INIT "Release")
set(EXECUTABLE_OUTPUT_PATH ${CMAKE_BINARY_DIR}/bin)
set(LIBRARY_OUTPUT_PATH ${EXECUTABLE_OUTPUT_PATH})


project(Lunatic)

find_package(Lua 5.1 REQUIRED)
find_package(PythonLibs 2.7 REQUIRED)


add_subdirectory(src)

add_library(python MODULE $<TARGET_OBJECTS:src>)
set_target_properties(python PROPERTIES
PREFIX "")

add_library(lua MODULE $<TARGET_OBJECTS:src>)
if (WIN32)
set_target_properties(lua PROPERTIES
PREFIX ""
SUFFIX ".pyd")
else (WIN32)
set_target_properties(lua PROPERTIES
PREFIX "")
endif (WIN32)

target_link_libraries(lua ${LUA_LIBRARIES} ${PYTHON_LIBRARIES})
target_link_libraries(python ${LUA_LIBRARIES} ${PYTHON_LIBRARIES})
cmake_minimum_required(VERSION 3.12.0)

set(CMAKE_BUILD_TYPE_INIT "Release")
set(EXECUTABLE_OUTPUT_PATH ${CMAKE_BINARY_DIR}/bin)
set(LIBRARY_OUTPUT_PATH ${EXECUTABLE_OUTPUT_PATH})

project(Lunatic)

find_package(Lua 5.1 REQUIRED)
find_package(Python REQUIRED COMPONENTS Interpreter Development)

add_subdirectory(src)

add_library(python MODULE $<TARGET_OBJECTS:src>)
set_target_properties(python PROPERTIES
PREFIX "")

add_library(lua MODULE $<TARGET_OBJECTS:src>)
if (WIN32)
set_target_properties(lua PROPERTIES
PREFIX ""
SUFFIX ".pyd")
else (WIN32)
set_target_properties(lua PROPERTIES
PREFIX "")
endif (WIN32)

target_link_libraries(lua ${LUA_LIBRARIES} ${Python_LIBRARIES})
target_link_libraries(python ${LUA_LIBRARIES} ${Python_LIBRARIES})
38 changes: 19 additions & 19 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
add_library(src OBJECT luainpython.c pythoninlua.c)
set_target_properties(src PROPERTIES
POSITION_INDEPENDENT_CODE TRUE)
target_include_directories(src PRIVATE ${LUA_INCLUDE_DIR} ${PYTHON_INCLUDE_DIR})
target_compile_definitions(src PRIVATE LUA_LIB)
if (WIN32)
target_compile_definitions(src PRIVATE LUA_BUILD_AS_DLL)
endif (WIN32)
if (UNIX)
get_filename_component(PYTHON_LIBRT ${PYTHON_LIBRARIES} NAME)
target_compile_definitions(src PRIVATE PYTHON_LIBRT=${PYTHON_LIBRT})
endif (UNIX)
if (CMAKE_COMPILER_IS_GNUCC)
target_compile_options(src PUBLIC -Wall -pedantic -std=c99)
endif (CMAKE_COMPILER_IS_GNUCC)
add_library(src OBJECT luainpython.c pythoninlua.c)
set_target_properties(src PROPERTIES
POSITION_INDEPENDENT_CODE TRUE)

target_include_directories(src PRIVATE ${LUA_INCLUDE_DIR} ${Python_INCLUDE_DIRS})

target_compile_definitions(src PRIVATE LUA_LIB)
if (WIN32)
target_compile_definitions(src PRIVATE LUA_BUILD_AS_DLL)
endif (WIN32)

if (UNIX)
get_filename_component(PYTHON_LIBRT ${Python_LIBRARIES} NAME)
target_compile_definitions(src PRIVATE PYTHON_LIBRT=${PYTHON_LIBRT})
endif (UNIX)

if (CMAKE_COMPILER_IS_GNUCC)
target_compile_options(src PUBLIC -Wall -pedantic -std=c99)
endif (CMAKE_COMPILER_IS_GNUCC)