Also include win/* when creating sdist package#110
Closed
nils-werner wants to merge 1 commit intobastibe:masterfrom
nils-werner:manifest
Closed
Also include win/* when creating sdist package#110nils-werner wants to merge 1 commit intobastibe:masterfrom nils-werner:manifest
nils-werner wants to merge 1 commit intobastibe:masterfrom
nils-werner:manifest
Conversation
Contributor
Contributor
Author
|
Another solution could be to catch errors in that move section of |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed the following under windows
pip install pysoundfiledoes not work because the dll files do not exist andshutil.copy2fails.pip install -e .does work, because this way, the dll files do exist.This has to do with the
win/directory not being included inMANIFEST.inand thusly not being included in thetar.gzfile when you dopython setup.py sdist.This PR fixes that, making sure that the dll files are included in future PyPI releases of this package.