Skip to content

Also include win/* when creating sdist package#110

Closed
nils-werner wants to merge 1 commit intobastibe:masterfrom
nils-werner:manifest
Closed

Also include win/* when creating sdist package#110
nils-werner wants to merge 1 commit intobastibe:masterfrom
nils-werner:manifest

Conversation

@nils-werner
Copy link
Contributor

I have noticed the following under windows

  • pip install pysoundfile does not work because the dll files do not exist and shutil.copy2 fails.
  • Cloning the repository from GitHub and doing pip install -e . does work, because this way, the dll files do exist.

This has to do with the win/ directory not being included in MANIFEST.in and thusly not being included in the tar.gz file when you do python setup.py sdist.

This PR fixes that, making sure that the dll files are included in future PyPI releases of this package.

@mgeier
Copy link
Contributor

mgeier commented Mar 3, 2015

For reference: #88, #98.

@nils-werner
Copy link
Contributor Author

Another solution could be to catch errors in that move section of setup.py. Because currently, no matter if I have libsndfile anywhere or not, pip install pysoundfile just fails.

@nils-werner nils-werner mentioned this pull request Mar 3, 2015
@bastibe bastibe modified the milestone: 0.7.0 Mar 4, 2015
@bastibe bastibe self-assigned this Mar 4, 2015
@nils-werner nils-werner closed this Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants