Conversation
mgeier
added a commit
that referenced
this pull request
Mar 9, 2015
mgeier
added a commit
that referenced
this pull request
Mar 10, 2015
Contributor
Author
|
I added a commit that should implement the changes: 1ebcb89 |
Owner
|
Shouldn't this change a test as well? If not, it should have ;-) Anyway, looks good to me. |
Contributor
Author
|
You're right, I forgot the tests, my bad! I'll fix the tests ... |
Contributor
Author
|
I amended my commit, fixing one test and removing another (d39b332). There is already a test case I hope now it's OK? |
Owner
|
Looks good to me. If you're happy with it, merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will revert the changes from #77.
Raising an error by default is useful in some cases, but it can also be harmful in other cases.
As far as I know, in most APIs the "write" function overwrites by default.
Also, e.g., the Unix commands
cpandmvby default overwrite their target.I think it's reasonable to assume that users expect overwriting behavior, therefore we should give it to them.
Once the default is changed to overwriting behavior, the argument
exclusive_creationisn't that relevant anymore and it should be removed.If users want to make sure that a file is not overwritten, they'll either have to check the existence first (e.g. with
os.path.exists()) or they can usef = SoundFile(..., mode='x').