Skip to content

refactor _read_or_write#139

Closed
bastibe wants to merge 1 commit intomasterfrom
split_read_write
Closed

refactor _read_or_write#139
bastibe wants to merge 1 commit intomasterfrom
split_read_write

Conversation

@bastibe
Copy link
Owner

@bastibe bastibe commented May 22, 2015

This separates the data conversion for CFFI from the function selection.

This is a continuation of the discussion in #138 .

@mgeier
Copy link
Contributor

mgeier commented May 27, 2015

I don't see an improvement from passing a string to passing a function object (while adding 2 new functions that only differ in the substring 'read' vs. 'write'), but I can live with it since it's only a minor implementation detail.

But the real problem is still unsolved: the error checking is separated from the code that relies on it.
I think this is solved in a less complicated manner in #138 (with less levels of indirection and IMHO easier to read), but if you prefer your way, you should at least call _check_array() inside of _read() resp. _write()!

@mgeier
Copy link
Contributor

mgeier commented May 27, 2015

Probably we should skip the discussion here and implement #72 instead, because this potentially changes the same code (again) ...

But first, I think it would be a good time to release 0.7.1!

@mgeier mgeier added this to the 0.8.0 milestone Sep 27, 2015
@bastibe
Copy link
Owner Author

bastibe commented Sep 30, 2015

superseded by #72.

@bastibe bastibe closed this Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants