Merged
Conversation
In new-style classes the base class __setattr__() has to be called instead of inserting the value into self.__dict__. See http://docs.python.org/2/reference/datamodel.html#customizing-attribute-access
... in contrast to if frames == -1 This corresponds to the behaviour of standard Python file objects.
Owner
|
The rest looks fine. |
Contributor
Author
|
When re-writing commits in pull requests, the old comments seem to get lost from the discussion view, e.g. the one on b40650c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some of the smaller, more innocuous changes proposed and discussed in #22 which in turn is based on #18.
@bastibe: please have a quick look if everything seems OK.
I just want to have those out of the way before tackling the major changes in file formats, modes, and all the other things from #18.