Skip to content

Change argument checking in SoundFile.__init__()#65

Closed
mgeier wants to merge 1 commit intomasterfrom
open-rw2
Closed

Change argument checking in SoundFile.__init__()#65
mgeier wants to merge 1 commit intomasterfrom
open-rw2

Conversation

@mgeier
Copy link
Contributor

@mgeier mgeier commented Aug 14, 2014

This is an alternative to #60. Both are possible solutions to #59.

Advantages of this solution:

  • the built-in open() function is not needed
  • the file argument is straightforwardly passed to libsndfile

Disadvantages of this solution:

  • the error messages after failing to open a file are just guesses. They may be misleading?
  • if arguments are specified even if they are not needed, they are ignored (instead of raising an error)

More or less neutral points:

  • the behavior is closer to libsndfile than to Python's open() function
  • read and write positions can be handled independently

Check arguments after calling libsndfile instead of before.
@mgeier
Copy link
Contributor Author

mgeier commented Aug 19, 2014

I'm closing this because we decided to use #60 instead.

@mgeier mgeier closed this Aug 19, 2014
@mgeier mgeier deleted the open-rw2 branch August 19, 2014 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant