Skip to content

deprecate indexing of SoundFile #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastibe merged 2 commits into from
Dec 2, 2014
Merged

deprecate indexing of SoundFile #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501ccab
added deprecation warning to indexing operations
bastibe Nov 28, 2014
d2badea
elevated DeprecationWarning to plain Warning
bastibe Dec 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pysoundfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,9 @@ def __len__(self):
def __getitem__(self, frame):
# access the file as if it where a Numpy array. The data is
# returned as numpy array.
from warnings import warn
warn('indexing has been deprecated and will be removed in the future',
Warning)
second_frame = None
if isinstance(frame, tuple):
if len(frame) > 2:
Expand All @@ -776,6 +779,9 @@ def __setitem__(self, frame, data):
# access the file as if it where a one-dimensional Numpy
# array. Data must be in the form (frames x channels).
# Both open slice bounds and negative values are allowed.
from warnings import warn
warn('indexing has been deprecated and will be removed in the future',
Warning)
start, stop = self._get_slice_bounds(frame)
if stop - start != len(data):
raise IndexError(
Expand Down