Skip to content

Conversation

@hummer2k
Copy link

@hummer2k hummer2k commented Sep 1, 2020

  • Run $ laminas-migration migrate on code base
  • Reorder namespace imports
  • Test php versions 7.2, 7,3 and 7.4
  • Migrate phpunit

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 82.902% when pulling 6fddf80 on hummer2k:laminas-migration into ddc7f55 on basz:master.

@hummer2k hummer2k marked this pull request as draft September 2, 2020 11:15
@hummer2k
Copy link
Author

hummer2k commented Sep 2, 2020

@sasezaki @basz Should we drop PHP < 7.3 support?
7.2 support is going to end in 2 months: https://www.php.net/supported-versions.php

@basz
Copy link
Owner

basz commented Sep 2, 2020

sounds fine by me, but I'm not using this package anymore... saver would be to release with 7.2 support, then drop 7.2 in an other release...

@hummer2k
Copy link
Author

hummer2k commented Sep 2, 2020

Oh, I overlooked that the laminas migration has already been done in #107

@hummer2k hummer2k closed this Sep 2, 2020
@hummer2k hummer2k deleted the laminas-migration branch September 2, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants