Fix ServiceLocator 2.x dependency injection for UriPathStrategy #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svycka
requested changes
Sep 14, 2017
| public function __invoke(ContainerInterface $container, $requestedName, array $options = null) | ||
| { | ||
| $strategy = new UriPathStrategy($container->get('router')); | ||
| $strategy = new UriPathStrategy($container->getServiceLocator()->get('router')); |
Collaborator
There was a problem hiding this comment.
this will not work on ServiceManager v3 instead add this to createService() method and then change
$strategy->setServiceLocator($container);
to:
$strategy->setServiceLocator($container->get(\SlmLocale\Strategy\StrategyPluginManager::class));
Contributor
Author
There was a problem hiding this comment.
Hey @svycka , thanks for the help, but I don't really feel comfortable making the final code change since I don't understand the v3 ServiceManager (I'm also no expert with v2).
This pull request was more just to point out where the problem is and my little workaround.
I'd appreciate it if you could make the change. Thanks for the quick responses!
|
|
||
| use Zend\ServiceManager\AbstractPluginManager; | ||
| use Zend\ServiceManager\Factory\InvokableFactory; | ||
| use SlmLocale\Strategy\Factory\UriPathStrategyFactory; |
Collaborator
There was a problem hiding this comment.
as you can see cs fixer want this to be above other use statements
Collaborator
|
fixed in #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: I have not ran unit testing on this code!
Please review well, but it fixes issue #89 for me. I have no experience with zend-service-manager 3.0, but it works for me in 2.7.x
Hope this helps