fix(webpack): stop page reloads on twig file save#11
Open
moacode wants to merge 1 commit into
Open
Conversation
|
Personally I quite like it that my page gets reloaded when I update a template. Not too fussed either way though |
Member
Yes, me too @rb1193! Obviously I don't mind as I'm not on the tools so much these days but perhaps we can chat together about this one at stand up tomorrow. |
Member
|
As discussed in the standup meeting this morning, we've decided to continue to reload twig files on save however add a flag/ environment variable to allow this to be overridden for devs that need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mikedaviesweb this one is for you 🍺🍺🍺🍺🍺🍺
What I did
A simple change to the dev server
watchOptions-->ignoredsetting to prevent the web page from reloading when twig files are saved.How to test
Note: A simple way to test is to fire up the craft starter project and replace the contents of
webpack.dev.jsin yournode_moduleswith the file from this repo.