Skip to content

feat: tailwindcss perf#22

Merged
moacode merged 6 commits into
masterfrom
feat/tailwindcss-perf
Nov 19, 2020
Merged

feat: tailwindcss perf#22
moacode merged 6 commits into
masterfrom
feat/tailwindcss-perf

Conversation

@moacode
Copy link
Copy Markdown

@moacode moacode commented Nov 17, 2020

Description

This PR improves TailwindCSS dev build performance by splitting up the various imports as per this tutorial.

Please merge in (or use) this PR while testing this feature.

Fixes #21

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested locally and observed a much faster build time.

@moacode
Copy link
Copy Markdown
Author

moacode commented Nov 17, 2020

@mikedaviesweb it would be great if you could check that I've set up the app-{base|components|utilities}.css files correctly (especially the fonts.css import).

@moacode moacode self-assigned this Nov 17, 2020
@moacode moacode changed the title Feat/tailwindcss perf feat: tailwindcss perf Nov 17, 2020
@mikedaviesweb
Copy link
Copy Markdown

Hey @thejoshsmith, looks good, this is how I did it on Te Pou with a few extra files.

app-base.css
app-components.css
app-utilities.css
base.css
fonts.css
components/components-container.css

Copy link
Copy Markdown
Contributor

@judereid judereid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

Comment thread src/js/app.js Outdated
@mikedaviesweb
Copy link
Copy Markdown

@thejoshsmith let's roll with the structure by default.

app-base.css
app-components.css
app-utilities.css
base/fonts.css
base/variables.css
components/
utilities/

Copy link
Copy Markdown

@rb1193 rb1193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me chaps

Josh Smith added 2 commits November 19, 2020 15:49
@moacode moacode merged commit 6431364 into master Nov 19, 2020
@moacode moacode deleted the feat/tailwindcss-perf branch November 19, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate tailwind imports

4 participants