Skip to content

Conversation

@jwheeler31
Copy link

@jwheeler31 jwheeler31 commented Oct 19, 2021

This is essentially a copy/paste of assert_equal. However, unlike assert_equal, I think it's more correct to perform the equivalence test surrounding each operand in double quotes (see assert_equal.bash#35 vs assert_not_equal.bash#35).

This would also close #31 .

@jwheeler31
Copy link
Author

Bump

Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

@martin-schulze-vireso martin-schulze-vireso merged commit 34551b1 into bats-core:master Nov 4, 2021
@jwheeler31
Copy link
Author

@martin-schulze-vireso First open source PR! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assert_notequal missing?

2 participants