Fix Java bindings using short instead of boolean for some methods#108
Open
HalfVoxel wants to merge 1 commit intobattlecode:masterfrom
Open
Fix Java bindings using short instead of boolean for some methods#108HalfVoxel wants to merge 1 commit intobattlecode:masterfrom
HalfVoxel wants to merge 1 commit intobattlecode:masterfrom
Conversation
Contributor
|
Oh, dang, hm. Unfortunately this is a breaking-change to the API, and given our update system I don't want to break people's code underneath them. Maybe it would be best to define some new methods called e.g. queueResearchBool? That will require some plumbing though. |
Contributor
Author
|
Well... Considering how much people are complaining about it being that way in Discord. I don't think people will complain much when it is fixed. |
|
please just fix it. tag everyone in the discord. it's awful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now things like this work
instead of having to do