Do manual line buffering in Python#149
Merged
kazimuth merged 1 commit intobattlecode:masterfrom Jan 26, 2018
Merged
Conversation
Contributor
Author
|
Oh, and I've tested this in both docker and nodocker on Linux, not on other OSes though (maybe Windows is weird with certain types of sockets). |
Contributor
Author
|
(Note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the Python overhead by a factor ~5-10 (!). Previously when our program ran for like 10ms Python accounted for 30ms and made it difficult not to time out; now that becomes ~3-6ms.
Conflicts somewhat with #147, and makes #148 rather less important (though it's probably still a good idea).